Upgrade "shadow" to 4.2.1 #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, sorry this doesn't work because newuidmap opens file with |
|
Ok, now |
| @@ -504,6 +582,14 @@ in { | |||
| # for backwards compatibility | |||
| system.activationScripts.groups = stringAfter [ "users" ] ""; | |||
|
|
|||
| # We must put actual files in /etc/subuid and /etc/subgid | |||
| # because newuidmap and newgidmap opens files with O_NOFOLLOW | |||
| # as a security measure | |||
There was a problem hiding this comment.
You can use environment.etc to copy files, if you set the mode option. See e.g. the sudo.nix module.
There was a problem hiding this comment.
Cool. Fixed. Also rebased to the latest master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
/etc/subuidand/etc/subgidmappings in user-groups moduleThose commands and files are useful for user namespaces (for example for running linux containers by non-root users)
Note: the module overwrites both
/etc/subuidand/etc/subgidon rebuild. Hopefully imperative manipulation of the files is not needed because of:The "shadow" 4.2.1 is used in archlinux since 2014-05-10. And ubuntu seems to use some patched version of 4.1.x that includes "newuidmap" and "newgidmap" commands.